Improve K8s unit tests #4196
Merged
Improve K8s unit tests #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
81f7cb7
to
8a43489
Compare
Signed-off-by: Paolo Di Tommaso <[email protected]>
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the unit tests for K8s pod specs by verifying specific pod spec fields instead of the entire pod spec. As a result the tests are shorter and faster, and when a test fails its easier to tell which fields are incorrect.
These tests have always been
difficultcumbersome to maintain, so hopefully this PR will make K8s development easier in the future.